Define wchar_t according to __WCHAR_TYPE__ #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1431 +/- ##
==========================================
- Coverage 56.38% 56.37% -0.02%
==========================================
Files 1902 1902
Lines 94566 94597 +31
==========================================
+ Hits 53322 53328 +6
- Misses 41244 41269 +25 |
kaidokert
reviewed
Aug 29, 2023
kaidokert
reviewed
Aug 29, 2023
b/246854012 Windows platform modular builds don't work with the current definition of wchar_t. Setting wchar_t according to the predefined C macro __WCHAR_TYPE__ ensures that wchar_t is defined correctly. Change-Id: I30eee6687820b19a1f18ef217b71b2c214cff98d
niranjanyardi
force-pushed
the
musl_fix_wchar
branch
from
07a302e
to
ebd374d
Compare
y4vor
approved these changes
Aug 31, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
b/298211986 b/246854012 Windows platform modular builds don't work with the current definition of wchar_t for c files. Setting wchar_t according to the predefined C macro __WCHAR_TYPE__ ensures that wchar_t is defined correctly. Error shows up here: b/246854012#comment41 and was discussed in go/lbreview/260401 (cherry picked from commit 474b3db)
niranjanyardi
added a commit
that referenced
this pull request
Sep 20, 2023
b/298211986 b/246854012 Windows platform modular builds don't work with the current definition of wchar_t for c files. Setting wchar_t according to the predefined C macro __WCHAR_TYPE__ ensures that wchar_t is defined correctly. Error shows up here: b/246854012#comment41 and was discussed in go/lbreview/260401 (cherry picked from commit 474b3db)
niranjanyardi
added a commit
that referenced
this pull request
Sep 20, 2023
Refer to the original PR: #1431 b/298211986 b/246854012 Windows platform modular builds don't work with the current definition of wchar_t for c files. Setting wchar_t according to the predefined C macro __WCHAR_TYPE__ ensures that wchar_t is defined correctly. Error shows up here: b/246854012#comment41 and was discussed in go/lbreview/260401 Co-authored-by: Niranjan Yardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/298211986
b/246854012
Windows platform modular builds don't work with the current definition of wchar_t for c files.
Setting wchar_t according to the predefined C macro WCHAR_TYPE ensures that wchar_t is defined correctly.
Error shows up here: b/246854012#comment41 and was discussed in go/lbreview/260401