Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to gcs download script #1471

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

oxve
Copy link
Contributor

@oxve oxve commented Sep 1, 2023

b/211897434

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1471 (fb90673) into main (1e8fbb4) will decrease coverage by 0.02%.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
- Coverage   56.39%   56.37%   -0.02%     
==========================================
  Files        1902     1902              
  Lines       94597    94607      +10     
==========================================
- Hits        53345    53333      -12     
- Misses      41252    41274      +22     

see 11 files with indirect coverage changes

tools/download_from_gcs.py Outdated Show resolved Hide resolved
tools/download_from_gcs.py Outdated Show resolved Hide resolved
tools/download_from_gcs.py Show resolved Hide resolved
@oxve
Copy link
Contributor Author

oxve commented Sep 1, 2023

I tested this change on all internal windows devel builds and it passed.

tools/download_from_gcs.py Outdated Show resolved Hide resolved
@oxve oxve merged commit 4c332a0 into youtube:main Sep 5, 2023
342 checks passed
@oxve oxve deleted the gcs-download-retry-simple branch September 5, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants