Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --no-install-recommends and patcher from Android Dockerfile #1892

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

isarkis
Copy link
Member

@isarkis isarkis commented Nov 2, 2023

This prevents circular dependency with ca-certificates and default-jdk during docker container build.

b/308476033

This prevents circular dependency with ca-certificates and default-jdk during docker container build.

b/308476033
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Nov 2, 2023

Datadog Report

Branch report: isarkis-patch-7
Commit report: f779d63

cobalt: 0 Failed, 0 New Flaky, 29568 Passed, 1 Skipped, 10m 2.37s Wall Time

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.78%. Comparing base (72a37d5) to head (f779d63).
Report is 1674 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1892   +/-   ##
=======================================
  Coverage   57.77%   57.78%           
=======================================
  Files        1915     1915           
  Lines       95111    95118    +7     
=======================================
+ Hits        54953    54964   +11     
+ Misses      40158    40154    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isarkis
Copy link
Member Author

isarkis commented Nov 2, 2023

@kaidokert, was --no-install-recommends added to keep our containers smaller? If so, would it make sense to figure out what recommended package fixes default-jdk installation, and install just that one? This might take time to figure out.

@isarkis
Copy link
Member Author

isarkis commented Nov 3, 2023

Spoke with Oscar offline, we decided to add TODO and open b/309157124.

@isarkis isarkis changed the title Remove --no-install-recommends from Android Dockerfile Remove --no-install-recommends and patcher from Android Dockerfile Nov 6, 2023
@isarkis isarkis merged commit d69b5a8 into main Nov 6, 2023
693 of 694 checks passed
@isarkis isarkis deleted the isarkis-patch-7 branch November 6, 2023 21:19
@isarkis isarkis added the cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch label Nov 29, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
…1892)

This prevents circular dependency with ca-certificates and default-jdk
during docker container build.

b/308476033

(cherry picked from commit d69b5a8)
isarkis added a commit that referenced this pull request Nov 29, 2023
… Android Dockerfile (#2028)

Refer to the original PR: #1892

This prevents circular dependency with ca-certificates and default-jdk
during docker container build.

b/308476033

---------

Co-authored-by: Igor Sarkisov <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
…outube#1892)

This prevents circular dependency with ca-certificates and default-jdk
during docker container build.

b/308476033
@kaidokert kaidokert added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Apr 13, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Apr 13, 2024
…1892)

This prevents circular dependency with ca-certificates and default-jdk
during docker container build.

b/308476033

(cherry picked from commit d69b5a8)
kaidokert pushed a commit that referenced this pull request Apr 13, 2024
… Android Dockerfile (#2932)

Refer to the original PR: #1892

This prevents circular dependency with ca-certificates and default-jdk
during docker container build.

b/308476033

Co-authored-by: Igor Sarkisov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch ignore-for-release on_device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants