-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --no-install-recommends and patcher from Android Dockerfile #1892
Conversation
This prevents circular dependency with ca-certificates and default-jdk during docker container build. b/308476033
Datadog ReportBranch report: ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1892 +/- ##
=======================================
Coverage 57.77% 57.78%
=======================================
Files 1915 1915
Lines 95111 95118 +7
=======================================
+ Hits 54953 54964 +11
+ Misses 40158 40154 -4 ☔ View full report in Codecov by Sentry. |
@kaidokert, was --no-install-recommends added to keep our containers smaller? If so, would it make sense to figure out what recommended package fixes default-jdk installation, and install just that one? This might take time to figure out. |
Spoke with Oscar offline, we decided to add TODO and open b/309157124. |
… Android Dockerfile (#2028) Refer to the original PR: #1892 This prevents circular dependency with ca-certificates and default-jdk during docker container build. b/308476033 --------- Co-authored-by: Igor Sarkisov <[email protected]>
…outube#1892) This prevents circular dependency with ca-certificates and default-jdk during docker container build. b/308476033
… Android Dockerfile (#2932) Refer to the original PR: #1892 This prevents circular dependency with ca-certificates and default-jdk during docker container build. b/308476033 Co-authored-by: Igor Sarkisov <[email protected]>
This prevents circular dependency with ca-certificates and default-jdk during docker container build.
b/308476033