Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CORS preflight request upon command line flag #3943

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

johnxwork
Copy link
Contributor

@johnxwork johnxwork commented Aug 7, 2024

b/27175039

@johnxwork johnxwork added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Aug 7, 2024
We were still sending preflight request even when cors is disabled by
dev flag.

b/27175039

Change-Id: Ib8dba31d581c44f77e623742b565ed9396448ea1
@johnxwork johnxwork merged commit d4ec2d6 into youtube:main Aug 7, 2024
331 of 333 checks passed
@johnxwork johnxwork deleted the cors branch August 7, 2024 17:34
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 7, 2024
Copy link
Member

@jellefoks jellefoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this LGTM

johnxwork added a commit that referenced this pull request Aug 9, 2024
…e flag (#3946)

Refer to the original PR: #3943

b/27175039

Co-authored-by: johnx <[email protected]>
@johnxwork johnxwork added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Aug 9, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 9, 2024
johnxwork added a commit that referenced this pull request Aug 9, 2024
…e flag (#3961)

Refer to the original PR: #3943

b/27175039

Co-authored-by: johnx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants