Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove SB14 code" #3956

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Revert "Remove SB14 code" #3956

merged 1 commit into from
Aug 9, 2024

Conversation

madhurajayaraman
Copy link
Contributor

@madhurajayaraman madhurajayaraman commented Aug 8, 2024 •
edited
Loading

b/355449840

Reverts #3902

@madhurajayaraman madhurajayaraman enabled auto-merge (squash) August 8, 2024 23:17
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 9, 2024 •
edited
Loading

Datadog Report

Branch report: revert-3902-sb17_api_cleanup3
Commit report: 5074e6e
Test service: cobalt

✅ 0 Failed, 34443 Passed, 6 Skipped, 10m 9.88s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • DeleteExpiredPartitionedCookiesAfterTimeElapsed_GetAllCookies - CookieMonsterTest - Last Failure

    Expand for error 
     ../../net/cookies/cookie_monster_unittest.cc:2372
 Expected equality of these values:
   1u
     Which is: 1
   get_cookies_callback2.cookies().size()
     Which is: 2

@madhurajayaraman madhurajayaraman merged commit a075f8b into main Aug 9, 2024
331 of 334 checks passed
@madhurajayaraman madhurajayaraman deleted the revert-3902-sb17_api_cleanup3 branch August 9, 2024 01:15
osagie98 pushed a commit to osagie98/cobalt that referenced this pull request Aug 9, 2024
@madhurajayaraman @osagie98
Revert "Remove SB14 code" (youtube#3956)
21315bd 
b/355449840

Reverts youtube#3902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhurajayaraman @kaidokert