Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test readdir_r symlink handling #3971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test readdir_r symlink handling #3971

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61245ef
Test readdir_r symbolic file handling
haozheng-cobalt Aug 13, 2024
ba44a15
Merge branch 'main' into readdir
haozheng-cobalt Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions starboard/nplb/posix_compliance/posix_directory_get_next_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#include <dirent.h>

#include <fcntl.h>
#include <unistd.h>
#include <queue>
#include <set>
#include <string>
Expand Down Expand Up @@ -216,6 +218,45 @@ TEST(PosixDirectoryGetNextTest, FailureOnInsufficientSize) {
EXPECT_TRUE(closedir(directory) == 0);
}

TEST(PosixDirectoryGetNextTest, SymlinkHandling) {
// std::string path = GetTempDir(); this temp dir caches many other files.
std::string path = GetTempDir();
path += "/test_sym";

int mkdir_result = mkdir(path.c_str(), 0777);
EXPECT_TRUE(mkdir_result == 0);

std::string symlink_path = path + "/symlink";
std::string target_path = path + "/target";

int fd = open(target_path.c_str(), O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR);
EXPECT_TRUE(fd != -1);
close(fd);

int result = symlink(target_path.c_str(), symlink_path.c_str());
EXPECT_EQ(result, 0) << "Failed to create symlink: " << strerror(errno);

DIR* directory = opendir(path.c_str());
EXPECT_TRUE(directory) << "Can't open: " << path;

int found = false;
while (true) {
struct dirent dirent_buffer;
struct dirent* dirent;
result = readdir_r(directory, &dirent_buffer, &dirent);
if (result || !dirent) {
break;
}

if (dirent->d_type == DT_LNK) {
EXPECT_STREQ(dirent->d_name, "symlink");
found = true;
}
}

EXPECT_TRUE(closedir(directory) == 0);
EXPECT_TRUE(found);
}
} // namespace
} // namespace nplb
} // namespace starboard
Loading