Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cobalt 24 LTS docker-compose.yml with changes from Main branch #3990

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

arjungm
Copy link
Contributor

@arjungm arjungm commented Aug 14, 2024

This version of the docker file brings the 24.lts version in sync with Main's version. This will enable building 24.lts images with Docker-in-Docker.

b/339046920

This commit squashes changes from these bugs:
b/333270679
b/266761312
b/335357085
b/323184809
b/268244534
b/297387435
b/289252639
b/264712142
b/297387435
b/297387435
b/245490832
b/245490832
b/295919088

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please back out the changes that would change the toolchain version. We should not / cannot change toolchain that significantly on a stable branch

@arjungm arjungm force-pushed the arjun-update-docker-compose-file-24 branch from 3e946e5 to 0609186 Compare August 15, 2024 19:21
This version of the docker file brings the 24.lts version in sync with
Main's version. This will enable building 24.lts images with
Docker-in-Docker.

b/339046920

This commit squashes changes from these bugs:
b/333270679
b/266761312
b/335357085
b/323184809
b/268244534
b/297387435
b/289252639
b/264712142
b/297387435
b/297387435
b/245490832
b/245490832
b/295919088
@arjungm arjungm force-pushed the arjun-update-docker-compose-file-24 branch from 0609186 to eb84f74 Compare August 15, 2024 20:21
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@kaidokert kaidokert merged commit 5e687ee into 24.lts.1+ Aug 15, 2024
323 checks passed
@kaidokert kaidokert deleted the arjun-update-docker-compose-file-24 branch August 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants