Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stub for cross-thread MediaSource attachments #4169

Merged

Commits on Sep 27, 2024

  1. Create stub for cross-thread MediaSource attachments

    Enables MediaSource, SourceBuffer, and SourceBufferList objects to be created
    on Dedicated Workers. Creation of these objects is not gated behind any H5VCC
    flags, but they will be non-transferable without usage of H5VCC flags.
    
    The initial implementation of CrossThreadMediaSourceAttachment is very bare
    bones, and does not allow for MediaElements to interact with the attached
    MediaSources yet. However, this lays the groundwork for supporting creating
    the relevant MediaSource objects on the worker thread, and the transfer
    process to get the reference back to the main thread.
    
    Usage of creating MediaSource URLs is gated through the
    `MediaSource.EnableInWorkers` H5VCC flag, in addition to existing flags
    `MediaElement.EnableUsingMediaSourceBufferedRange` and
    `MediaElement.EnableUsingMediaSourceAttachmentMethods`. If and only if all
    three flags are enabled, MediaSources created on Dedicated Workers and passed
    to `URL.createObjectURL` will return a non-empty string that can be sent to
    the main thread, and used to 'access' the MediaSourceAttachment. In addition,
    if and only if all three H5VCC flags are enabled,
    [`MediaSource.canConstructInDedicatedWorker`](https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/canConstructInDedicatedWorker_static)
    will return true.
    
    This is based on the following Chromium commit:
    
    • https://chromium-review.googlesource.com/c/chromium/src/+/2407075
    
    b/338425449
    at-ninja committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d23bf06 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Address review comments

    at-ninja committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4a78000 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Address review comments

    at-ninja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    73b76f9 View commit details
    Browse the repository at this point in the history