Fix UDP socket sending compatibility with older Starboard builds #4337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellefoks
force-pushed
the
fix_udp_socket_connections_for_older_starboard
branch
3 times, most recently
from
e2d9600
to
f1cccf8
Compare
jellefoks
force-pushed
the
fix_udp_socket_connections_for_older_starboard
branch
from
f1cccf8
to
41543cf
Compare
yjzhang111
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starboard builds that don't include #4270 hard assert when sending a UDP packet without a destination address, even on connected sockets.
This fixes that by supplying the remote address, unless the
"dev.cobalt.extension.SocketReceiveMultiMsg"extension from #4321 is also implemented for the platform. As a result, platforms that implement the extension will still get the full performance benefit of relying on connected UDP sockets.b/374155470
b/373726636
b/205134049
b/369965331