Fix send for connected UDP socket

starboard/shared/posix/socket_bind.cc

@@ -68,5 +68,6 @@ SbSocketError SbSocketBind(SbSocket socket,
     return (socket->error = sbposix::TranslateSocketErrno(errno));
   }
 
+  socket->is_connected = true;
   return (socket->error = kSbSocketOk);
 }

starboard/shared/posix/socket_connect.cc

@@ -53,5 +53,6 @@ SbSocketError SbSocketConnect(SbSocket socket, const SbSocketAddress* address) {
     return (socket->error = kSbSocketErrorFailed);
   }
 
+  socket->is_connected = true;
   return (socket->error = kSbSocketOk);
 }

starboard/shared/posix/socket_internal.h

@@ -32,7 +32,8 @@ struct SbSocketPrivate {
         protocol(protocol),
         socket_fd(fd),
         error(kSbSocketOk),
-        waiter(kSbSocketWaiterInvalid) {}
+        waiter(kSbSocketWaiterInvalid),
+        is_connected(false) {}
   ~SbSocketPrivate() {}
 
   // The address domain of this socket, IPv4 or IPv6.
@@ -49,6 +50,9 @@ struct SbSocketPrivate {
 
   // The waiter this socket is registered with, or kSbSocketWaiterInvalid.
   SbSocketWaiter waiter;
+
+  // Whether this socket is connected or not.
+  bool is_connected;
 };
 
 namespace starboard {

starboard/shared/posix/socket_send_to.cc

@@ -57,31 +57,47 @@ int SbSocketSendTo(SbSocket socket,
     socket->error = sbposix::TranslateSocketErrno(errno);
     return -1;
   } else if (socket->protocol == kSbSocketProtocolUdp) {
-    sbposix::SockAddr sock_addr;
-    const sockaddr* sockaddr = NULL;
-    socklen_t sockaddr_length = 0;
-    if (destination) {
-      if (!sock_addr.FromSbSocketAddress(destination)) {
-        SB_LOG(FATAL) << "Invalid destination passed to UDP send.";
-        socket->error = kSbSocketErrorFailed;
-        return -1;
+    if (socket->is_connected) {
+      ssize_t bytes_written =
+          send(socket->socket_fd, data, data_size, kSendFlags);
+      if (bytes_written >= 0) {
+        socket->error = kSbSocketOk;
+        return static_cast<int>(bytes_written);
       }
-      sockaddr = sock_addr.sockaddr();
-      sockaddr_length = sock_addr.length;
-    }
 
-    ssize_t bytes_written = sendto(socket->socket_fd, data, data_size,
-                                   kSendFlags, sockaddr, sockaddr_length);
-    if (bytes_written >= 0) {
-      socket->error = kSbSocketOk;
-      return static_cast<int>(bytes_written);
-    }
+      if (errno != EAGAIN && errno != EWOULDBLOCK) {
+        SB_LOG(ERROR) << "send failed, errno = " << errno;
+      }
+      socket->error = sbposix::TranslateSocketErrno(errno);
+      return -1;
+    } else {
+      sbposix::SockAddr sock_addr;
+      const sockaddr* sockaddr = NULL;
+      socklen_t sockaddr_length = 0;
 
-    if (errno != EAGAIN && errno != EWOULDBLOCK) {
-      SB_LOG(ERROR) << "sendto failed, errno = " << errno;
+      if (destination) {
+        if (!sock_addr.FromSbSocketAddress(destination)) {
+          SB_LOG(FATAL) << "Invalid destination passed to UDP send.";
+          socket->error = kSbSocketErrorFailed;
+          return -1;
+        }
+        sockaddr = sock_addr.sockaddr();
+        sockaddr_length = sock_addr.length;
+      }
+
+      ssize_t bytes_written = sendto(socket->socket_fd, data, data_size,
+                                     kSendFlags, sockaddr, sockaddr_length);
+      if (bytes_written >= 0) {
+        socket->error = kSbSocketOk;
+        return static_cast<int>(bytes_written);
+      }
+
+      if (errno != EAGAIN && errno != EWOULDBLOCK) {
+        SB_LOG(ERROR) << "sendto failed, errno = " << errno;
+      }
+      socket->error = sbposix::TranslateSocketErrno(errno);
+      return -1;
     }
-    socket->error = sbposix::TranslateSocketErrno(errno);
-    return -1;
   }
 
   SB_NOTREACHED() << "Unrecognized protocol: " << socket->protocol;