Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set environment variable IS_CI #4432

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Set environment variable IS_CI #4432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89410f
Set environment variable IS_CI
niranjanyardi Nov 14, 2024
be96bec
Address feedback
niranjanyardi Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cobalt/build/gn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ def write_build_args(build_args_path, original_lines, dict_settings,
f'The following args cannot be set in configs: {controlled_args}')
gen_comment = '# Set by gn.py'
with open(build_args_path, 'w', encoding='utf-8') as f:
if os.getenv('USE_RBE', default='0') == '0':
f.write(f'cc_wrapper = "{CC_WRAPPER}" {gen_comment}\n')
else:
if os.getenv('IS_CI', default='0') == '0':
niranjanyardi marked this conversation as resolved.
Show resolved Hide resolved
f.write(f'use_remoteexec = true {gen_comment}\n')
else:
f.write(f'cc_wrapper = "{CC_WRAPPER}" {gen_comment}\n')
f.write(f'build_type = "{build_type}" {gen_comment}\n')
for key, value in _BUILD_TYPES[build_type].items():
f.write(f'{key} = {value} {gen_comment}\n')
Expand Down
1 change: 1 addition & 0 deletions cobalt/docker/linux/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ ENV SCCACHE_GCS_BUCKET=githubactions-chrome-sccache
ENV SCCACHE_GCS_RW_MODE=READ_WRITE
ENV SCCACHE_GCS_KEY_PATH=/root/key.json
ENV SCCACHE_GCS_SERVICE_ACCOUNT=github-actions-bucket-access@cobalt-demo-330821.iam.gserviceaccount.com
ENV IS_CI=1
niranjanyardi marked this conversation as resolved.
Show resolved Hide resolved
Loading