cobalt/ force Starboard platform and EGL+GLES2 #4601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 11678 Passed, 0 Skipped, 2m 18.3s Total Time |
TyHolc
approved these changes
Dec 18, 2024
Yeah, should be fine to add those here. Note that until the other crashes are addressed that this will crash due to --ozone-platform=starboard (when normally it would default to x11) |
|
Had a better way in #4607 , let me close this CL in favour of that one. |
yell0wd0g
added a commit
that referenced
this pull request
Dec 18, 2024
This CL adds the command line option --use-gl=egl if not present, or enforces that this is the value passed to the program. This is to avoid falling back to Angle, which is undesired at the moment. This CL replaces #4601 which had a different approach. Bug: b/371272304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from @TyHolc 's #4538 , this CL just hardcodes two command line flags, namely to use the starboard Ozone platform and to force EGL for windowing API (which in turn forces GLES2 see here); using eGL is meant to avoid using or falling back to Angle.