-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UWP] Use a shared output queue for sw av1 and vpx decoder #461
Conversation
bf1e853
to
9ac6084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple comments but overall looks good to me. I'll leave it up to @osagie98 to review the media changes.
9ac6084
to
57b3029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as this doesn't create unnecessary memory pressure. I have a few small comments.
57b3029
to
e74d7ed
Compare
Pay attention, this PR must be merge together with CL233700. These updates depend each other. |
e74d7ed
to
bc40dfb
Compare
bc40dfb
to
eb0ec8f
Compare
Can this be merged ? @osagie98 would you go ahead and take care of internal part as well ? |
The internal part is reviewed by @jasonzhangxx |
eb0ec8f
to
a4dd2a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 56.36% 56.90% +0.53%
==========================================
Files 1902 1898 -4
Lines 94554 94100 -454
==========================================
+ Hits 53298 53550 +252
+ Misses 41256 40550 -706 |
b3e17fb
to
61dba60
Compare
e5caac6
to
4f7eaaf
Compare
4f7eaaf
to
2347d10
Compare
Reorganize output queue. Use one large preallocated hw buffer for sw decoders. b/249739051 Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49
Reorganize output queue. Use one large preallocated hw buffer for both av1 & vpx sw decoders b/249739051 Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49 (cherry picked from commit 43abe39)
Reorganize output queue. Use one large preallocated hw buffer for both av1 & vpx sw decoders b/249739051 Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49 (cherry picked from commit 43abe39)
…px decoder (#1380) Refer to the original PR: #461 Reorganize output queue. Use one large preallocated hw buffer for both av1 & vpx sw decoders b/249739051 Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49 Co-authored-by: victorpasoshnikov <[email protected]>
Reorganize output queue. Use one large preallocated hw buffer for both av1 & vpx sw decoders
b/249739051
Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49