Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Use a shared output queue for sw av1 and vpx decoder #461

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

victorpasoshnikov
Copy link
Collaborator

Reorganize output queue. Use one large preallocated hw buffer for both av1 & vpx sw decoders

b/249739051

Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49

Copy link
Contributor

@TyHolc TyHolc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments but overall looks good to me. I'll leave it up to @osagie98 to review the media changes.

Copy link
Contributor

@osagie98 osagie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as this doesn't create unnecessary memory pressure. I have a few small comments.

@victorpasoshnikov
Copy link
Collaborator Author

Pay attention, this PR must be merge together with CL233700. These updates depend each other.

@kaidokert
Copy link
Member

Can this be merged ? @osagie98 would you go ahead and take care of internal part as well ?

@victorpasoshnikov
Copy link
Collaborator Author

The internal part is reviewed by @jasonzhangxx

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #461 (98f10b2) into main (20b44b2) will increase coverage by 0.53%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 98f10b2 differs from pull request most recent head f18c1e4. Consider uploading reports for the commit f18c1e4 to get more accurate results

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   56.36%   56.90%   +0.53%     
==========================================
  Files        1902     1898       -4     
  Lines       94554    94100     -454     
==========================================
+ Hits        53298    53550     +252     
+ Misses      41256    40550     -706     

see 306 files with indirect coverage changes

Reorganize output queue.
Use one large preallocated hw buffer for sw decoders.

b/249739051

Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49
@TyHolc TyHolc merged commit 43abe39 into youtube:main Aug 21, 2023
331 checks passed
@TyHolc TyHolc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Aug 23, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 23, 2023
Reorganize output queue. Use one large preallocated hw buffer for both
av1 & vpx sw decoders

b/249739051

Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49
(cherry picked from commit 43abe39)
TyHolc pushed a commit that referenced this pull request Sep 20, 2023
Reorganize output queue. Use one large preallocated hw buffer for both
av1 & vpx sw decoders

b/249739051

Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49
(cherry picked from commit 43abe39)
TyHolc pushed a commit that referenced this pull request Sep 20, 2023
…px decoder (#1380)

Refer to the original PR: #461

Reorganize output queue. Use one large preallocated hw buffer for both
av1 & vpx sw decoders

b/249739051

Change-Id: I6430ae1ba5d288ed2495f3056cc7283f5c189f49

Co-authored-by: victorpasoshnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants