Initial pass at event mapping #4678
Open
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally, numbers etc work. |
y4vor
reviewed
Jan 10, 2025
| @@ -60,6 +61,141 @@ constexpr auto kSbKeyToDomCodeMap = base::MakeFixedFlatMap<SbKey, ui::DomCode>({ | |||
| {kSbKeyChannelDown, ui::DomCode::CHANNEL_DOWN}, | |||
| {kSbKeyClosedCaption, ui::DomCode::CLOSED_CAPTION_TOGGLE}, | |||
| {kSbKeyRecord, ui::DomCode::MEDIA_RECORD}, | |||
|
|
|||
| // 0-9, a-z | |||
| {kSbKey0, ui::DomCode::DIGIT0}, | |||
There was a problem hiding this comment.
Try to create a new function of class that is self contained and does the translation. You can add unit test and submit it main.
Take a look at: https://source.chromium.org/chromium/chromium/src/+/main:ui/events/x/x11_event_translation.cc
or
https://source.chromium.org/chromium/chromium/src/+/main:ui/events/fuchsia/pointer_events_handler.cc
There was a problem hiding this comment.
+1, in particular to the unit test part (unit tests for an opinionated mapping can be straightforward, and that's fine).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mappings from kSbKeyFoo to ui::DomCode::Bar .