Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media] Move calls to GetPlayerStateName() #4679

Merged
merged 4 commits into from
Jan 15, 2025
Merged

[media] Move calls to GetPlayerStateName() #4679

merged 4 commits into from
Jan 15, 2025

Conversation

osagie98
Copy link
Contributor

b/376316272

@osagie98 osagie98 requested a review from xiaomings January 10, 2025 00:02
@osagie98 osagie98 mentioned this pull request Jan 10, 2025
Merged
@osagie98
Copy link
Contributor Author

If we follow this path, we may log in if (!player_bridge_) that the function is called when player_bridge_ is nullptr, as the current log of the state will be replaced by the one in the very beginning of the function. We may also turn it into a LOG(WARNING).

Not sure I understood 100%, I have two logs, one WARNING for a null player bridge, and the other is INFO. Did you want a single WARNING log?

@osagie98 osagie98 requested a review from xiaomings January 13, 2025 19:31
@osagie98 osagie98 enabled auto-merge (squash) January 14, 2025 18:11
@osagie98 osagie98 merged commit a028ee6 into youtube:main Jan 15, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaomings xiaomings xiaomings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osagie98 @xiaomings