Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#CheckWithTech: Better handle users without Slack #178

Merged
merged 4 commits into from
Oct 15, 2024
Merged

#CheckWithTech: Better handle users without Slack #178

merged 4 commits into from
Oct 15, 2024

Conversation

markspolakovs
Copy link
Member

Do this twofold:

  • After submitting a request, if they don't have a Slack identity prompt to link
  • If they still don't have one by the time we go to approve, show a message to that effect

@jenkins-ystv
Copy link

jenkins-ystv bot commented Oct 15, 2024

Deployed a preview of this PR to https://pr-178-internal.dev.ystv.co.uk

archessmn
archessmn approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@archessmn archessmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just made some UI changes

@markspolakovs markspolakovs merged commit 912a24f into main Oct 15, 2024
3 checks passed
@markspolakovs markspolakovs deleted the mp/better-handle-users-without-slack branch October 15, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archessmn archessmn archessmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markspolakovs @archessmn