Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @slack/bolt version and make slackApp available globally #191

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

archessmn
Copy link
Member

This should fix the console spam of slack struggling to stay connected and also only require one slackApp to be made per instance running.

@jenkins-ystv
Copy link

jenkins-ystv bot commented Oct 23, 2024

Deployed a preview of this PR to https://pr-191-internal.dev.ystv.co.uk

server/index.ts Outdated Show resolved Hide resolved
Also add invariant checks to ensure multiple apps aren't created

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 16 changed files in this pull request and generated no suggestions.

Files not reviewed (10)
  • package.json: Language not supported
  • features/calendar/check_with_tech.ts: Evaluated as low risk
  • server/index.ts: Evaluated as low risk
  • features/userFeedback/index.ts: Evaluated as low risk
  • features/calendar/check_with_tech_actions.ts: Evaluated as low risk
  • app/(authenticated)/calendar/[eventID]/actions.ts: Evaluated as low risk
  • app/(authenticated)/calendar/[eventID]/signUpSheetActions.ts: Evaluated as low risk
  • lib/auth/slack/index.ts: Evaluated as low risk
  • components/slack/SlackUserInfo.tsx: Evaluated as low risk
  • components/slack/SlackChannelsProvider.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

lib/slack/slackApiConnection.ts:27

  • The error message should indicate that a global app does not exist, as the function is supposed to create one if it doesn't. Suggested message: "createSlackApp was called but a global app does not exist".
invariant((globalThis as unknown as { slackApp: App | undefined }).slackApp, "createSlackApp was called but a global app already exists");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants