[WEB-139] Error handling and checks on creation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WEB-139 Slack integration can't be added to an existing channel
Error: |
| users: user.slack_user_id, | ||
| }); | ||
| // Check if channel exists from previous API calls | ||
| if (channel_info?.ok) { |
There was a problem hiding this comment.
Doesn’t the API client throw an error, instead of returning a non-ok response object?
Change thrown errors to returned messages that will get displayed properly to the client.
components/SlackChannelField.tsx
Outdated
| @@ -37,6 +38,11 @@ export default function SlackChannelField(props: { parentName: string }) { | |||
|
|
|||
| return ( | |||
| <> | |||
| {ctx.formState.errors.slack_channel && ( | |||
There was a problem hiding this comment.
Should this use props.parentName somehow?
markspolakovs
approved these changes
Feb 4, 2024
components/SlackChannelField.tsx
Outdated
| @@ -38,13 +38,13 @@ export default function SlackChannelField(props: { parentName: string }) { | |||
|
|
|||
| return ( | |||
| <> | |||
| {ctx.formState.errors.slack_channel && ( | |||
| {ctx.formState.errors[`${props.parentName}`] && ( | |||
There was a problem hiding this comment.
nitpick: this can just be formState.errors[props.parentName]
markspolakovs
deleted the
web-139-slack-integration-cant-be-added-to-an-existing-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some Error handling and other various checks before channel creation / channel join / channel invite