-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-143] Adding basic permissions #81
[WEB-143] Adding basic permissions #81
Conversation
…functions don't play well together
WEB-143 No permissions
There is no list of permissions for each role or descriptions Can't add, edit, delete or list permissions |
Either @markspolakovs or @archessmn would like a review, evidently only one person can be requested in private repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got the same concern about this as I did in web-auth - permissions are something that's only used by code, so there shouldn't be a reason to add a custom one through UI (or even worse, delete one that is used by a role), so I'm not sure how useful it is to have a UI for managing them. In fact I'd consider replacing Permission
with a Prisma enum type to guard this (I recall me and @probablybenallen having a discussion about this)
Ah I see, should I consider all the current permissions in the calendar2023_prod database or different ones? |
They're defined here: (I can't remember why we used a string rather than an enum type mind you) |
I think I know why, you can't have a period in the enum name |
That wasn't the reason (it was a long discussion), but it might be a reason. |
Ah okay |
Reconverted to using the enums again |
Once I get the roles and users sorted then I can finalise everything, @markspolakovs anything else you think should be changed? |
d32a53b
into
web-140-there-is-no-current-admin-ui
This will be the basis of adding permissions, not complete as I will need both WEB-141 and WEB-142 for a complete integration, hence merging to this branch rather than main