-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-1: embed and live main page #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a solid bit of work, just got a couple of questions on it. Also, no worries if not, but if you could post a screenshot of what this would look like, that would be great
components/HomeLiveBanner/index.tsx
Outdated
<small> | ||
YSTV will be going live soon, tune it at{" "} | ||
{new Date(channel.scheduledStart).toLocaleTimeString( | ||
"en-US", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be en-GB
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know it does not affect timezones - just formatting, it's just the least faff way of converting time to 12hr with an AM and no seconds without introducing a third party library (I've been trying to keep js bloat to a minimum on public-site), en-GB does 24hr clock which didn't look as user friendly to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, I did see en-GB
used elsewhere, are we wanting it swapped there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, because that's where I wanted the date only so I need "en-GB" so it gets the day and month the right way around. Should probably add that as comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, yeah a comment would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, have left a comment on the en-GB
thing, but I'm content for this to be merged regardless
should get us all the features we need for roses with some time to test it beforehand...?