Merge pull request #351 from ysugimoto/fix/base64-decode-builtin-func…

…tions

Fix tiny bug of base64 decode functions

cmd/falco/runner_test.go

@@ -358,6 +358,12 @@ func TestTester(t *testing.T) {
 			filter: "*override_variables.test.vcl",
 			passes: 6,
 		},
+		{
+			name:   "base64 functional test",
+			main:   "../../examples/testing/base64/main.vcl",
+			filter: "*base64.test.vcl",
+			passes: 12,
+		},
 	}
 
 	for _, tt := range tests {

examples/testing/base64/base64.test.vcl

@@ -0,0 +1,66 @@
+// https://fiddle.fastly.dev/fiddle/a3b006c4
+
+// @scope: recv
+// @suite: Test base64 decode
+sub test_base64_decode_recv {
+    declare local var.input STRING;
+    declare local var.decoded STRING;
+
+    set var.input = "aGVsbG8=0";
+
+    set var.decoded = digest.base64_decode(var.input);
+    assert.equal(std.strlen(var.decoded), 5);
+    assert.equal(var.decoded, "hello");
+
+    set var.decoded = digest.base64url_decode(var.input);
+    assert.equal(std.strlen(var.decoded), 5);
+    assert.equal(var.decoded, "hello");
+
+    set var.decoded = digest.base64url_nopad_decode(var.input);
+    assert.equal(std.strlen(var.decoded), 6);
+    assert.equal(var.decoded, "hello4");
+}
+
+// @scope: recv
+// @suite: Test base64 decode NULL string
+sub test_base64_decode_recv {
+    declare local var.input STRING;
+    declare local var.decoded STRING;
+
+    set var.input = "c29tZSBkYXRhIHdpdGggACBhbmQg77u/";
+
+    set var.decoded = digest.base64_decode(var.input);
+    assert.equal(std.strlen(var.decoded), 15);
+    assert.equal(var.decoded, "some data with ");
+
+    set var.decoded = digest.base64url_decode(var.input);
+    assert.equal(std.strlen(var.decoded), 15);
+    assert.equal(var.decoded, "some data with ");
+
+    set var.decoded = digest.base64url_nopad_decode(var.input);
+    assert.equal(std.strlen(var.decoded), 15);
+    assert.equal(var.decoded, "some data with ");
+}
+
+// @scope: recv
+// @suite: Test base64 decode BOM string
+sub test_base64_decode_recv {
+  // Skip tests because we suspects Fastly has a tiny bug in base64 decoding with BOM 
+    declare local var.input STRING;
+    declare local var.decoded STRING;
+
+    set var.input = "c29tZSBkYXRhIHdpdGgg77u/IGFuZCAA";
+
+    // set var.decoded = digest.base64_decode(var.input);
+    // assert.equal(std.strlen(var.decoded), 23);
+    # assert.equal(var.decoded, "some data with \xef\xbb\xbf and");
+
+    // set var.decoded = digest.base64url_decode(var.input);
+    // assert.equal(std.strlen(var.decoded), 22);
+    # assert.equal(var.decoded, "some data with ﻈ[�");
+
+    // set var.decoded = digest.base64url_nopad_decode(var.input);
+    // assert.equal(std.strlen(var.decoded), 22);
+    # assert.equal(var.decoded, "some data with ﻈ[�");
+}
+

examples/testing/base64/main.vcl

@@ -0,0 +1,5 @@
+# https://fiddle.fastly.dev/fiddle/6a433b2e
+
+backend default_0 {
+  .host = "example.com";
+}