querystring functions reimplemented #264
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so they don't parse query string and instead try to preserve the original as much as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #258 which is only a partial fix.
The behavior of this new implementation is more consistent with Fastly.
The original falco implementation parses the original value into a structure, then manipulates it and then converts back to string representation. This has several unwanted side effects such changing key and value encoding as well as changing parameter order.
Instead of fully parsing the input string, new implementation attempts to only split it to pieces as necessary.
The premise is that split operation is fully reversible with join.
Also new implementation attempts to follow Fastly quirks. For instance in some cases (filter) '?' is automatically removed if operation result leads to empty query. In some other cases (sort) it is preserved even if query string is empty.
This fastly fiddle contains (mostly) the same test cases as those in the associated unit tests.