feat: add dap subcommand and support basic DAP features
#349
Conversation
that contains basic functions to handle dap requests https://microsoft.github.io/debug-adapter-protocol/specification Signed-off-by: Rintaro Okamura <[email protected]>
to launch dap server Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
falco's dap feature is proposed in ysugimoto/falco#349 Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
|
@rinx |
dap/debugger.go
Outdated
|
|
||
| path, err := filepath.Abs(meta.Token.File) | ||
| if err != nil { | ||
| // TODO: handle error |
There was a problem hiding this comment.
How should we treat for the error?
In terms of ast.Node, falco always treat as absolute path so meta.Token.File always has an absolute path.
Therefore you don't need to get the absolute path using filepath.Abs.
Additionally, falco may retrieves Fastly remote reources like acl, backend, etc then the remote source file will be Remote.Acl.[name] and the the getBreakpoint` works fine even not a filepath?
There was a problem hiding this comment.
Thank you for your comment. I've just fixed it!
Additionally, falco may retrieves Fastly remote reources like
acl,backend, etc then the remote source file will beRemote.Acl.[name]and the the getBreakpoint` works fine even not a filepath?
Currently, it doesn't matter because dap subcommand does not support remote resources feature.
We need to implement it as a future work.
Signed-off-by: Rintaro Okamura <[email protected]>
Refs: ysugimoto#349 (comment) Signed-off-by: Rintaro Okamura <[email protected]>
This pull request adds
dapsubcommand and basic Debug Adapter Protocol (DAP) features.Falco already has a VCL debugger.
It's better to integrate DAP features with it, however the current debugger is highly coupled with TUI console.
Not to break compatibility, at the first step, I implemented DAP features as separated subcommand.
Demo
In my Neovim environment, it works like below:
