-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add podAntiAffinity for masters in demo cfg, fix yqlAgent count for 0.9.1 #392
base: main
Are you sure you want to change the base?
Conversation
@@ -15,6 +15,16 @@ spec: | |||
primaryMasters: | |||
instanceCount: 3 | |||
cellTag: 1 | |||
affinity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without it, this error will appear:
The Ytsaurus "ytdemo" is invalid: spec.primaryMasters.affinity.podAntiAffinity: Required value: Masters should be placed on different nodes
i added fix to 0.9.1 and to file without version (is it latest version?), don't know if it's applicable to previous versions
Oh, hi, Oleg |
@koct9i what do you think? Maybe |
Not sure if we should change 0.9.1 also, i guess it must be checked with 0.9.1 operator and maybe it doesn't have such check yet. Not sure if we even need samples for different versions (especially old ones), I guess we need to preserve latest and maybe some of the previous and update them on release (it would also be good to test them automatically). |
it's up to you (that is |
Probably we could resurrect default anti-affinity for masters (but not in form defaulter webhook) and adjust validation. Also it would be nice to validate sample config in unit test |
No description provided.