Skip to content

Commit

Permalink
Merge pull request #3091 from rybnico/dnos-add-hidden-secrets
Browse files Browse the repository at this point in the history
dnos: Hide more secrets
  • Loading branch information
robertcheramy authored Mar 1, 2024
2 parents 68d9438 + 57598a6 commit 1499c4f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
14 changes: 7 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [Unreleased]

## Added
### Added
- model for D-Link cisco like CLI (@mirackle-spb)
- model for Ruijie Networks RGOS devices (@spike77453)
- Add serial number collection to Opengear (@ermuller)
Expand All @@ -21,7 +21,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- model for Fibrestore (fs.com) FSOS (@tcrichton)
- model for IP Infusion OcNOS

## Changed
### Changed
- tp-link: fixed enable mode post login entrance (@mirackle-spb)
- dlink: fixed prompt for other dlink switches, added additional uptime removal expressions (@mirackle-spb)
- Collect VC info for juniper ex3400 (@ermuller)
Expand All @@ -36,10 +36,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- pfsense: exclude autogenerated firewall rule timestamps to reduce change churn from use of stuff like PFBlockerNG #2985 (@anthonysomerset)
- ciscosmb: ignore "Please change the password" hint when doing backup. (@sharteeya)
- dlinknextgen removes user and snmp-server secrets (@tcrichton)
- dnos: hide secrets in "ospf message-digest-key", "authentication-type" and "bsd-username" (@rybnico)
- junos: Replace dynamic value in VMX-BANDWIDTH with count, hide ssh keys


## Fixed
### Fixed
- fixed empty lines for ZyXEL GS1900 switches (@jluebbe)
- fixed prompt for Watchguard FirewareOS not matching the regex when the node is non-master (@netdiver)
- defined 'psych' runtime dependency to resolve 'unsafe_load' error during startup (@MattKobayashi)
Expand All @@ -64,13 +64,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [0.29.1 - 2023-04-24]

## Added
### Added

## Changed
### Changed

- Ensure Docker builds are only pushed to registry on `master` (@aschaber1)

## Fixed
### Fixed

- #2749: fix issues with `cut_both`

Expand Down
3 changes: 3 additions & 0 deletions lib/oxidized/model/dnos.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ class DNOS < Oxidized::Model
cfg.gsub! /secret (\d+) (\S+).*/, '<secret hidden>'
cfg.gsub! /password (\d+) (\S+).*/, '<secret hidden>'
cfg.gsub! /^(tacacs-server key \d+) (\S+).*/, '\\1 <secret hidden>'
cfg.gsub! /(ip ospf message-digest-key \d \S+ \d).*/, '\\1 <secret hidden>'
cfg.gsub! /(authentication-type).*/, '\\1 <secret hidden>'
cfg.gsub! /^(bsd-username \S+ secret).*/, '\\1 <secret hidden>'
cfg
end

Expand Down

0 comments on commit 1499c4f

Please sign in to comment.