Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is.directory
/is.file
/fs.readdir
and the actualfs.watch
call.fs
API to transparently support files contained inasar
archives butfs.watch
does not work for them. (See Electron version struggles with app.asar FredrikNoren/ungit#1523)To test this I relied on the fact the the options are getting copied with
Object.assign({}, options, {...})
so that I could delete the directory beforefs.watch
is called but after theis.directory
/is.file
checks.Fixes #108