Fix: Fix 'No relation found' error for models using alias #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers, this is my first contribution, so if there are any guidelines or best practices I should follow, please let me know 😄
Since dbt-osmosis v1.x.x, the method for generating the
CatalogKey
has changed. In the current implementation, whenadapter.get_relation
is called for a dbt model that uses analias
,None
is returned.Until v0.14.0, if an alias was used, the alias would take priority, and that behavior was correct.
(ref. https://github.com/z3z1ma/dbt-osmosis/blob/v0.14.0/src/dbt_osmosis/core/osmosis.py#L324-L328)
So, I have modified it so that if it is neither a BaseRelation nor a NodeType.Source, the alias is used.
Test
Prepare Environment
Add dbt model files using alias
Build the deme_duckdb project
Before fixing
WARNING ⚠ No relation found => CatalogKey(database='jaffle_shop', schema='main', name='sample_alias')
is shown.After fixing