Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set response=True for write_gatt_char to fix silent failure #29

Merged
merged 2 commits into from
Nov 23, 2023
Merged

set response=True for write_gatt_char to fix silent failure #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff0cfff
set response=True for write_gatt_char to fix silent failure
tensorturtle Nov 21, 2023
85fd6bc
the rest
tensorturtle Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pycycling/fitness_machine_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,27 +192,27 @@ def _control_point_response_handler(
async def request_control(self) -> None:
message = form_ftms_control_command(FTMSControlPointOpCode.REQUEST_CONTROL)
await self._client.write_gatt_char(
ftms_fitness_machine_control_point_characteristic_id, message, False
ftms_fitness_machine_control_point_characteristic_id, message, True
)

async def reset(self) -> None:
message = form_ftms_control_command(FTMSControlPointOpCode.RESET)
await self._client.write_gatt_char(
ftms_fitness_machine_control_point_characteristic_id, message, False
ftms_fitness_machine_control_point_characteristic_id, message, True
)

async def set_target_resistance_level(self, level: int) -> None:
message = form_ftms_control_command(
FTMSControlPointOpCode.SET_TARGET_RESISTANCE_LEVEL, int(level)
)
await self._client.write_gatt_char(
ftms_fitness_machine_control_point_characteristic_id, message, False
ftms_fitness_machine_control_point_characteristic_id, message, True
)

async def set_target_power(self, power: int) -> None:
message = form_ftms_control_command(
FTMSControlPointOpCode.SET_TARGET_POWER, int(power)
)
await self._client.write_gatt_char(
ftms_fitness_machine_control_point_characteristic_id, message, False
ftms_fitness_machine_control_point_characteristic_id, message, True
)