Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binary i/o #160

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Conversation

robertozimek
Copy link
Contributor

many rust postgres drivers use binary transfer, so would be nice to be able to use h3 indexes without casting them to string.

Copy link
Owner

@zachasme zachasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertozimek. This looks great! I'm wondering if it would make more sense to send/receive the H3 uint64_t directly, instead of converting to string? Or is there a reason strings are preferable?

h3/sql/updates/h3--4.1.3--unreleased.sql Outdated Show resolved Hide resolved
@zachasme zachasme self-assigned this Nov 4, 2024
@zachasme zachasme added the enhancement 🚀 New feature or request label Nov 4, 2024
@robertozimek
Copy link
Contributor Author

Hi @robertozimek. This looks great! I'm wondering if it would make more sense to send/receive the H3 uint64_t directly, instead of converting to string? Or is there a reason strings are preferable?

Good point, I guess I was just thinking of the use case of using it directly as text for my use case in my rust project, but it makes sense that this data be transferred in it's raw form and the responsibility should falls on the consumer to do the translation, I'll update it once I get a chance.

Also any ideas on how to get the test working on windows, unfortunately I don't have a windows environment. (If anything I'll see about standing up a VM)

@zachasme
Copy link
Owner

zachasme commented Nov 5, 2024

If it makes sense to export the H3 uint64_t I think we should go with that. Out of interest, could you elaborate on how you are using this? :-)

I'll try fixing up the windows test, and get his merged right away!

@zachasme zachasme merged commit 6d1e2b0 into zachasme:main Nov 5, 2024
12 of 14 checks passed
@robertozimek
Copy link
Contributor Author

robertozimek commented Nov 5, 2024

If it makes sense to export the H3 uint64_t I think we should go with that. Out of interest, could you elaborate on how you are using this? :-)

I'll try fixing up the windows test, and get his merged right away!

Thanks for merging it in. So I'm working on a little project to be able to generate h3 tileset directly from a postgres datasource and serve them up for this deckgl H3TileLayer and also thinking of rewriting my other little project in rust. Not because they need to be in rust by any means just think they are good little project to help me learn and practice rust while also potentially provide some utility to any geospatial hobbyist out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants