let operator fix publications without tables #2722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the situation that a publication, slot and stream CRD were there but no publication tables. Not sure, how we ended up there. Maybe the stream operator created it after our operator did not block the slot and crd creation even when the table did not exist yet.
No publication tables leads to the following error in the operator:
To support NULL values one can use go.sql's NullString implementation to catch this. But what to do next then? Set publications[pubName] = nil? This would make a later comparison between desired and current tables impossible.
Instead, this PR suggest to return an empty string. On sync the diff should be noticed and the operator would alter the publication and set a new table list.