Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stream duplication on operator restart #2733

Merged
merged 3 commits into from
Aug 20, 2024
Merged

fix stream duplication on operator restart #2733

merged 3 commits into from
Aug 20, 2024

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Aug 19, 2024

With the refactoring in #2713 I removed one important part of syncing the streams: Fetching the current state from K8s API. Instead I looped over the new cluster struct field Streams which is always empty on start up. This will produce a new stream resource on ever operator pod start. Therefore, I added a delete logic to cleanup the ill-created duplicates.

The unit tests were extended to test syncing and removal as well as owner references update.

@FxKu FxKu added the bugfix label Aug 19, 2024
@FxKu FxKu added this to the 1.13.0 milestone Aug 19, 2024
@idanovinda
Copy link
Member

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Aug 20, 2024

👍

@FxKu FxKu merged commit 2f7e3ee into master Aug 20, 2024
12 checks passed
@FxKu FxKu deleted the stream-sync-fix branch August 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants