-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve guidance for caching support (#451) #482
Conversation
finished the review now - using the diff from IDEA fixed the problems of seeing what has changed. |
eb324ad
to
9c9197f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! -- generally fine contribution!
Just 1 non-editorial comment.
👍 |
1 similar comment
👍 |
Hey, The guidance you're giving sounds good to me in general, but there's a couple of things that 'd like to comment on:
Just a few ideas / doubts that came to my mind when reading this section 👍 |
fixes #451.
The main contributions are in chapters/performance.adoc:173-309 and a small extend in chapters/http-requests.adoc:229-250.
Sorry, that I again mixed some simple reformatting stuff in this commit - especially in chapters/common-headers.adoc. Unfortunately, the diff cannot show this very well.
However, I also mixed an extension to
Prefer
in chapters/common-headers.adoc:99-155.