Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update formatting for proprietary headers #652

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Update formatting for proprietary headers #652

merged 4 commits into from
Jun 29, 2021

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Apr 13, 2021

  • Use admonitions for hints, warnings, etc.
  • Fix small typos
  • Update headers format

Fixes #651

@vadeg
Update formatting for proprietary headers
39efee9 
* Use admonitions for hints, warnings, etc.
* Fix small typos
* Update headers format
tfrauenstein
tfrauenstein reviewed Apr 14, 2021
View reviewed changes
Copy link
Member

@tfrauenstein tfrauenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! -- see 2 comments.

Remark: It fixes only the consistent case-usage in the proprietary header definition -- not all aspects discussed in issue #651

chapters/proprietary-headers.adoc Outdated Show resolved Hide resolved
chapters/proprietary-headers.adoc Outdated Show resolved Hide resolved
@vadeg
Copy link
Contributor Author

vadeg commented May 19, 2021

The formatting has been reverted.

@tfrauenstein
Copy link
Member

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented May 25, 2021

👍

@tfrauenstein
Copy link
Member

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Jun 1, 2021

👍

@tkrop tkrop mentioned this pull request Jun 29, 2021
Merged
@tfrauenstein tfrauenstein merged commit 8fea64b into master Jun 29, 2021
@tfrauenstein tfrauenstein deleted the gh-651-update-headers-formatting branch August 24, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrop tkrop tkrop left review comments

@tfrauenstein tfrauenstein tfrauenstein left review comments

Assignees

@vadeg vadeg

Labels
editorial enhancement no-zally-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change proprietary headers format in the hint for Rule 183
3 participants
@vadeg @tfrauenstein @tkrop