chore: update lora notebook + fix order inputs in llama #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-stoian-zama
previously approved these changes
Dec 20, 2024
kcelia
reviewed
Dec 20, 2024
| @@ -4,6 +4,6 @@ peft==0.12.0 | |||
| Jinja2==3.1.4 | |||
| matplotlib==3.7.5 | |||
| datasets==3.1.0 | |||
| accelerate==1.2.0 | |||
| accelerate==1.0.1 | |||
There was a problem hiding this comment.
Which package the 1.2.0 version had conflicts with?
There was a problem hiding this comment.
1.2.0 isn't compatible with python 3.8. I will probably revert this and add a comment that we don't support 3.8 in this use case
kcelia
reviewed
Dec 20, 2024
| @@ -134,7 +133,7 @@ | |||
| { | |||
| "data": { | |||
| "application/vnd.jupyter.widget-view+json": { | |||
| "model_id": "9775e413ec264b2eb14ee53dbc381474", | |||
There was a problem hiding this comment.
Since the PR is red, I suggest some updates:
# Apply LoRA to the model.
# The 'target_modules' parameter can be set to "all-linear" to apply LoRA to all linear modules.
# By default, only the 'c_attn' projection layers are fine-tuned with LoRA.
There was a problem hiding this comment.
You can remove the extra spaces between the comment and the function:
# Since we've already handled padding and labels, we can use a custom data collator
def data_collator(features):
jfrery
force-pushed
the
update_lora_notebook
branch
from
56d002c to
c0094ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.