Support for localising regexps #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the first locale, IT, that we care for right now Needed improvements include a better way to package the local regular expressions
Add the first locale, IT, that we care for right now Needed improvements include a better way to package the local regular expressions
tests for all locales
- Is this what travis is really complaining about? Fix _test_test file name error for italian test
|
@kulpreet I like this configuration approach towards language specific regex. Going to take a closer look, resolve some issues, and get @kageurufu thoughts. |
|
I like the idea of this, although I would prefer to store the localized regex in something readable through the standard library instead of bringing in an extra dependency just to read YAML files. Perhaps even just have a python module and |
kageurufu
added a commit
that referenced
this pull request
Sep 22, 2016
Based on PR #18, modified to no longer require pyyaml This keeps email_reply_parser stdlib only, and allows easy addition of new locales without needing to parse config files
|
This looks great - is this library still maintained? It would be great to get language support in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to parse out emails for Italian users. All my users are Italian.
The regexps were all in English. I needed to support Italian regular expressions.
So I made some changes, which hopefully will allow other contributors to provide regular expressions in other languages.
Changes include:
EmailReplyParserclass to alocales.yamlfileEmailReplyParser.readandEmailReplyParser.parse_replyDependency added
pyyamlto parse thelocales.yaml. So added that tosetup.pyas arequiresandtests_requireoption.Possible Improvements
locales.yamlinsetupusingpackage_data. I am new to Python, so didn't make much progress on it. But if someone can advise me what is the best approach to allow setup/install/runtime selection of configuration options - I am happy to make those changes.