Allow to choose the name of report files #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r multiple target in same workflow Signed-off-by: atilsensalduz <[email protected]>
thc202
changed the title
|
The changelog should be updated |
thc202
reviewed
Mar 10, 2023
| json_report_name: | ||
| description: 'file to write the full ZAP JSON document' | ||
| required: false | ||
| default: 'report_json.json' |
There was a problem hiding this comment.
What happens if the user provides an empty string or an invalid file name?
There was a problem hiding this comment.
Thank you so much for reviewing 🙏 in that case, workflow returns error from zap-baseline.py. in my opinion, it would be better if we give that error handling to zap-baseline.py instead of handling in workflow. wdty?
There was a problem hiding this comment.
you're right 😄. I'm on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: parameterize-output-files to avoid report override when runs for multiple target in same workflow