Add unlisted flag #2113
Open
Add unlisted flag #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aryangupta701
commented
Sep 12, 2023
aryangupta701
commented
- use unlisted: true to not display a blog in the blog list
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: Aryan Gupta <[email protected]>
Signed-off-by: Aryan Gupta <[email protected]>
Signed-off-by: Aryan Gupta <[email protected]>
Signed-off-by: Aryan Gupta <[email protected]>
Signed-off-by: Aryan Gupta <[email protected]>
|
7 commits? |
|
Also shouldn't it also check the date in order to appear when appropriate? |
|
Can be squashed? or should I squash? |
|
Do we really need this? |
|
I think I should add that date check? |
thc202
reviewed
Sep 12, 2023
| @@ -9,6 +9,7 @@ <h1 class="text--white">{{ .Title }}</h1> | |||
| <div class="flex on-sm-stack"> | |||
| <div class="col-2-3 pr-30"> | |||
| {{ range .Pages }} | |||
| {{ if not .Params.unlisted }} | |||
There was a problem hiding this comment.
Better to be more specific that only applies to the blog index (e.g. it will still be listed in tags).
My question too 😉 |
|
Its up to you if you want to keep this or not. Maybe if you have any use case in future then you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.