Fixing eslint error messages on src/index.js #2786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Sep 3, 2024
Signed-off-by: Ana Rocha <[email protected]>
|
Hi @kingthorin, I've redone the commit with the changes again so you can check what was actually changed. |
|
Thank you, that makes it much easier to see what's been done 💯 |
kingthorin
reviewed
Sep 5, 2024
|
Yes, I tested the changes I made to the code and found no problems. |
|
The commit author needs to be reset. |
|
@anaaroch nudge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, as a part of a project from my university, the students of my class had to apply Clean Code principles to a open source project. I tryed tackling the issue #244 with Lucas Bergholz in a recent PR, but, when we were working on it, there were a lot of error messages coming from the eslint of the project.
This way, i tackled 67 of these error messages, applying the changes that eslint suggested. These changes help the project maintain patterns and facilitate future changes on this file.