Fix minimum numpy pin (#628)

* Fix minimum numpy pin * Make sure we test minimum version of numpy * swap import order --------- Co-authored-by: Norman Rzepka <[email protected]>
zarr-developers · Nov 9, 2024 · a7a698d · a7a698d
1 parent 35bd9e3
commit a7a698d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -72,6 +72,9 @@ jobs:
 
       - name: Install zarr-python
         shell: "bash -l {0}"
+        # Since zarr v3 requires numpy >= 1.25, on Python 3.11 leave it out
+        # so we can have some tests of our minimum version of numpy (1.24)
+        if: matrix.python-version != '3.11'
         run: |
           conda activate env
           # TODO: remove --pre option when zarr v3 is out

diff --git a/numcodecs/tests/test_zarr3.py b/numcodecs/tests/test_zarr3.py
@@ -3,10 +3,10 @@
 import numpy as np
 import pytest
 
-import numcodecs.zarr3
-
 zarr = pytest.importorskip("zarr")
 
+import numcodecs.zarr3  # noqa: E402
+
 pytestmark = [
     pytest.mark.skipif(zarr.__version__ < "3.0.0", reason="zarr 3.0.0 or later is required"),
     pytest.mark.filterwarnings("ignore:Codec 'numcodecs.*' not configured in config.*:UserWarning"),

diff --git a/pyproject.toml b/pyproject.toml
@@ -15,7 +15,7 @@ A Python package providing buffer compression and transformation codecs \
 for use in data storage and communication applications."""
 readme =  "README.rst"
 dependencies = [
-    "numpy>=1.23",
+    "numpy>=1.24",
 ]
 requires-python = ">=3.11"
 dynamic = [