-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jenkins lookup3 32-bit checksum #446
Add jenkins lookup3 32-bit checksum #446
Conversation
@rabernat Here's a cython implementation of jenkin's lookup3 32-bit checksum. |
I'm thinking of moving Also, I'm thinking about a |
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 55 56 +1
Lines 2121 2238 +117
==========================================
+ Hits 2121 2238 +117
|
test_jenkins.py is showing lots of lint errors |
Could someone run CI? |
Flake8 issues resolved |
I made some changes to
This was due to the if statement near the top of the file detecting the lack of sphinx, and then proceeding to try to print the "friendly" error message. However, it accomplishes exactly the opposite. |
I modified fletcher32 since the |
Let me know if you vwould prefer me to break this up a bit. I originally intended that but slipped in a |
Yes, please keep only the jenkins stuff in here. The other bits look OK I think, but it's better to keep PRs focussed where possible. |
Add Bob Jenkin's lookup3 from HDF5 via a Cython implementation
Fix #445
TODO: