Support Python 3.12 #471
Merged
Support Python 3.12 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The macOS Python 3.8 build has a weird error. Snippet below: c-blosc/blosc/bitshuffle-avx2.c:22:4: error: AVX2 is not supported by the target architecture/platform and/or this compiler.
#error AVX2 is not supported by the target architecture/platform and/or this compiler.
^
1 error generated.Wonder if we should just drop Python 3.8 based on NEP 29. Raising issue ( zarr-developers/community#65 ) to discuss |
|
Builds work. Nearly all tests pass However there is one CI error from the tests. It pertains to entrypoints. Snippet of the error below from CI: __________________ ERROR at setup of test_entrypoint_codec ____________________
@pytest.fixture()
def set_path():
sys.path.append(here)
> numcodecs.registry.run_entrypoints()
numcodecs/tests/test_entrypoints.py:15:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
def run_entrypoints():
entries.clear()
eps = entry_points()
if hasattr(eps, 'select'):
# If entry_points() has a select method, use that. Python 3.10+
> entries.update(eps.select(group="numcodecs.codecs"))
E ValueError: dictionary update sequence element #0 has length 3; 2 is required
numcodecs/registry.py:16: ValueError |
On Python 3.12, the existing code did not produce a `dict` that could be used to update `entries` whereas previous Python versions had. To workaround this issue, manually create a `dict` that can be used to update `entries` with a format consistent to what had been seen in Python versions before 3.12.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 2242 2242
=========================================
Hits 2242 2242
|
Closed
jakirkham
commented
Oct 4, 2023
Comment on lines
14
to
+16
| if hasattr(eps, 'select'): | ||
| # If entry_points() has a select method, use that. Python 3.10+ | ||
| entries.update(eps.select(group="numcodecs.codecs")) | ||
| entries.update({e.name: e for e in eps.select(group="numcodecs.codecs")}) |
There was a problem hiding this comment.
@martindurant could you please take a look at this change?
|
cc @joshmoore @MSanKeys963 @rabernat (in case any of you have time to review) |
|
Going to go ahead and merge to get the release out. Hope that is ok Happy to discuss further as needed |
6 tasks
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/numcodecs
that referenced
this pull request
Aug 10, 2024
* Support Python 3.12 * Ensure `entries.update(...)` recieves a `dict` On Python 3.12, the existing code did not produce a `dict` that could be used to update `entries` whereas previous Python versions had. To workaround this issue, manually create a `dict` that can be used to update `entries` with a format consistent to what had been seen in Python versions before 3.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Python 3.12.
TODO: