Disable AVX2 in macOS ARM wheels #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As AVX2 is an `x86_64` feature, ARM understandably doesn't have it. However for some reason macOS ARM wheels are building with this functionality enabled. So disable it in `pyproject.toml`. Hopefully this should fix that issue.
jakirkham
force-pushed
the
disable_avx2_macos_arm
branch
from
3f1d001
to
974e60e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
===========================================
+ Coverage 99.95% 100.00% +0.04%
===========================================
Files 56 56
Lines 2241 2242 +1
===========================================
+ Hits 2240 2242 +2
+ Misses 1 0 -1 |
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/numcodecs
that referenced
this pull request
Aug 10, 2024
As AVX2 is an `x86_64` feature, ARM understandably doesn't have it. However for some reason macOS ARM wheels are building with this functionality enabled. So disable it in `pyproject.toml`. Hopefully this should fix that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As AVX2 is an
x86_64feature, ARM understandably doesn't have it. However for some reason macOS ARM wheels are building with this functionality enabled. So disable it inpyproject.toml. Hopefully this should fix that issue.Fixes #473
TODO: