-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitinfo codec #503
Open
thodson-usgs
wants to merge
15
commits into
zarr-developers:main
Choose a base branch
from
thodson-usgs:adaptive-bitrounding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add bitinfo codec #503
thodson-usgs
wants to merge
15
commits into
zarr-developers:main
from
thodson-usgs:adaptive-bitrounding
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d7d792 - Browse repository at this point
Copy the full SHA 6d7d792View commit details -
Configuration menu - View commit details
-
Copy full SHA for e35221b - Browse repository at this point
Copy the full SHA e35221bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a97f7e8 - Browse repository at this point
Copy the full SHA a97f7e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f884113 - Browse repository at this point
Copy the full SHA f884113View commit details -
Configuration menu - View commit details
-
Copy full SHA for c04a6e3 - Browse repository at this point
Copy the full SHA c04a6e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03128f6 - Browse repository at this point
Copy the full SHA 03128f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ef603 - Browse repository at this point
Copy the full SHA 11ef603View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2e2394 - Browse repository at this point
Copy the full SHA f2e2394View commit details -
Revert info_per_bit tolerance to 1.5
The xbitinfo implementation uses a tolerance factor of 1.5. I lowered the tolerance to 1.1, because I was getting poor results with my test data, but it was pointed out that the problem was that my test data were quantized. Quantization is an open issue with xbitinfo too, and we should address it first there, then patch the codec.
Configuration menu - View commit details
-
Copy full SHA for 6b6fa4f - Browse repository at this point
Copy the full SHA 6b6fa4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 673d86b - Browse repository at this point
Copy the full SHA 673d86bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 157c57c - Browse repository at this point
Copy the full SHA 157c57cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45ab3c4 - Browse repository at this point
Copy the full SHA 45ab3c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78f93e3 - Browse repository at this point
Copy the full SHA 78f93e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 385c407 - Browse repository at this point
Copy the full SHA 385c407View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50dcea9 - Browse repository at this point
Copy the full SHA 50dcea9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.