Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build aarch64 wheels #563

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Aug 20, 2024

This PR:

  • Changes the cibuildwheel config to explicitly list the architectures to build for
  • Adds aarch64 to this list for linux builds
  • Restricts the number of wheels built on a PR to 1 per major platform (linux, windows, macOS x86_64, macOS arm64)
  • Builds all the wheels on release, or when the "build all wheels" label is added to a PR

This speeds up runs on PRs, but allows the flexibiility of doing a full run of wheel building if needed by adding the label.

Fixes #312, fixes #288, and an updated version of #315

TODO:

  • Changes documented in docs/release.rst
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@dstansby dstansby force-pushed the aarch64-wheels branch 4 times, most recently from b0591df to 4788c35 Compare August 20, 2024 19:52
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (4784a52) to head (689c3e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2334     2334           
=======================================
  Hits         2332     2332           
  Misses          2        2           

@dstansby dstansby force-pushed the aarch64-wheels branch 3 times, most recently from 31baffd to 182007e Compare August 23, 2024 14:48
@dstansby dstansby added the build all wheels Trigger GitHub actions to build all of the wheels on a PR label Aug 23, 2024
@dstansby dstansby marked this pull request as ready for review August 23, 2024 18:36
@dstansby dstansby removed the build all wheels Trigger GitHub actions to build all of the wheels on a PR label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run wheel builds selectively? Add support to release Linux aarch64 wheels
1 participant