End support for EOL python 3.5 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We've done the last release with compatibility with 3.5, though this now have conflicts, would you mind rebasing ? |
|
Indeed happy to +1 once conflicts are resolved :) |
Remove from CI and test configuration, setup.py, and tox.
|
Rebased! |
Carreau
approved these changes
Oct 7, 2020
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to 3.5 from CI and test configuration, setup.py, and tox, as per #602
Note that the ipython notebooks seem to have been run against 3.5; we should consider running them against 3.8 and check them in again to future-proof us a little longer.
Strictly, 3.5 only becomes EOL 2020-09-13, so take the weekend ;) As stated in zarr-developers/governance#11 it may be worth putting out a final patch version supporting 3.5 before this goes in.