new favicon

zauberzeug · Jul 21, 2021 · 941569e · 941569e
1 parent 2d359d8
commit 941569e
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -58,7 +58,7 @@ You can call `ui.run()` with optional arguments for some high-level configuratio
 - `host` (default: `'0.0.0.0'`)
 - `port` (default: `80`)
 - `title` (default: `'NiceGUI'`)
-- `favicon` (default: `'favicon.png'`)
+- `favicon` (default: `'favicon.ico'`)
 - `reload`: automatically reload the ui on file changes (default: `True`)
 - `show`: automatically open the ui in a browser tab (default: `True`)
 

diff --git a/nicegui/config.py b/nicegui/config.py
@@ -9,7 +9,7 @@ class Config(BaseModel):
     host: str = '0.0.0.0'
     port: int = 80
     title: str = 'NiceGUI'
-    favicon: str = 'favicon.png'
+    favicon: str = 'favicon.ico'
     reload: bool = True
     show: bool = True
 

diff --git a/nicegui/run.py b/nicegui/run.py
@@ -12,7 +12,7 @@
     uvicorn.run('nicegui:app', host=config.host, port=config.port, lifespan='on', reload=True)
     sys.exit()
 
-def run(self, *, host='0.0.0.0', port=80, title='NiceGUI', favicon='favicon.png', reload=True, show=True):
+def run(self, *, host='0.0.0.0', port=80, title='NiceGUI', favicon='favicon.ico', reload=True, show=True):
 
     if reload == False:  # NOTE: in case reload == True we already started uvicorn above
         if show:

diff --git a/nicegui/static/favicon.ico b/nicegui/static/favicon.ico
diff --git a/nicegui/static/favicon.png b/nicegui/static/favicon.png