shape version specified only once #1537
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improve-cube-validation #1537 +/- ##
===========================================================
- Coverage 74.68% 73.60% -1.08%
===========================================================
Files 219 220 +1
Lines 14927 14947 +20
Branches 846 850 +4
===========================================================
- Hits 11148 11002 -146
- Misses 3776 3936 +160
- Partials 3 9 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cli/lib/replace.ts
Outdated
| const prefix = 'https://cube.link/latest/' | ||
| const replacement = `https://cube.link/${version}/` | ||
| return through2.obj(function (quad: Quad, _, done) { | ||
| if (quad.predicate.value === 'https://code.described.at/imports' && quad.object.value.startsWith(prefix)) { |
There was a problem hiding this comment.
| if (quad.predicate.value === 'https://code.described.at/imports' && quad.object.value.startsWith(prefix)) { | |
| if (quad.predicate.equals(env.ns.code.imports && quad.object.value.startsWith(prefix)) { |
Of course you'd need to get env from step context
cli/pipelines/publish.ttl
Outdated
| code:implementedBy | ||
| [ | ||
| a code:EcmaScript ; | ||
| code:link <file:../lib/replace#default> |
There was a problem hiding this comment.
I think the step deserves a more descriptive name
is it a step in the right direction? I'm not sure the added complexity is worth it