-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shape version specified only once #1537
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improve-cube-validation #1537 +/- ##
===========================================================
- Coverage 74.68% 73.60% -1.08%
===========================================================
Files 219 220 +1
Lines 14927 14947 +20
Branches 846 850 +4
===========================================================
- Hits 11148 11002 -146
- Misses 3776 3936 +160
- Partials 3 9 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I think it's a good direction
cli/lib/replace.ts
Outdated
const prefix = 'https://cube.link/latest/' | ||
const replacement = `https://cube.link/${version}/` | ||
return through2.obj(function (quad: Quad, _, done) { | ||
if (quad.predicate.value === 'https://code.described.at/imports' && quad.object.value.startsWith(prefix)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (quad.predicate.value === 'https://code.described.at/imports' && quad.object.value.startsWith(prefix)) { | |
if (quad.predicate.equals(env.ns.code.imports && quad.object.value.startsWith(prefix)) { |
Of course you'd need to get env
from step context
cli/pipelines/publish.ttl
Outdated
code:implementedBy | ||
[ | ||
a code:EcmaScript ; | ||
code:link <file:../lib/replace#default> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the step deserves a more descriptive name
is it a step in the right direction? I'm not sure the added complexity is worth it