Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add custom compressible mime-types #473

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: add custom compressible mime-types #473

merged 2 commits into from
Aug 22, 2024

Conversation

Rdataflow
Copy link
Contributor

@Rdataflow Rdataflow commented Aug 21, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5ab61d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tpluscode
tpluscode reviewed Aug 21, 2024
View reviewed changes
packages/core/index.js Outdated Show resolved Hide resolved
@Rdataflow @t0b3
fix: add custom compressible mime-types
215aa83 
Closes: zazuko#472

compress query results still missing in mime-db
- n-triples
- n-quads
- trig

nb: all the others are already marked compressible in mime-db i.e.
- json
- xml
- csv
- tsv
- turtle
@ludovicm67
Copy link
Member

@Rdataflow Thank you for the PR ; it looks great from what I see!
I will quickly give it a try and report some feedback shortly :)

ludovicm67
ludovicm67 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@ludovicm67 ludovicm67 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌
I just added a commit to add support for parameterized content-types so that application/sparql-results+json; charset=utf-8 can be supported as expected.

@ludovicm67 ludovicm67 merged commit 8cafef5 into zazuko:main Aug 22, 2024
@Rdataflow Rdataflow deleted the add-compressible-mime-types branch August 22, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpluscode tpluscode tpluscode left review comments

@ludovicm67 ludovicm67 ludovicm67 approved these changes

Assignees
No one assigned
Labels
enhancement package:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mime-type n-triples isn't compressed
3 participants
@Rdataflow @ludovicm67 @tpluscode