Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yasgui types + some fixes #553

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Yasgui types + some fixes #553

merged 7 commits into from
Oct 29, 2024

Conversation

ludovicm67
Copy link
Member

This adds types and fix somes issues with the Yasgui plugin.

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: b6ad4ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
trifid-plugin-yasgui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ludovicm67 ludovicm67 marked this pull request as draft October 23, 2024 14:55
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (c5e668b) to head (b6ad4ef).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
packages/yasgui/plugins/map.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   70.55%   70.55%   -0.01%     
==========================================
  Files          54       54              
  Lines        3440     3450      +10     
==========================================
+ Hits         2427     2434       +7     
- Misses       1013     1016       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludovicm67 ludovicm67 marked this pull request as ready for review October 29, 2024 09:42
@ludovicm67 ludovicm67 merged commit e23399a into main Oct 29, 2024
6 checks passed
@ludovicm67 ludovicm67 deleted the yasgui-improvments branch October 29, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant