Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daira Emma Hopwood <[email protected]>
  • Loading branch information
nuttycom and daira authored Sep 1, 2023
1 parent 363dea9 commit 727cddd
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions zcash_client_backend/src/data_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,12 @@ impl AccountBirthday {
}

#[cfg(feature = "test-dependencies")]
/// Constructs a new [`AccountBirthday`] at Sapling activation, with no
/// "recover until" height.
///
/// # Panics
///
/// Panics if the Sapling activation height is not set.
pub fn from_sapling_activation<P: zcash_primitives::consensus::Parameters>(
params: &P,
) -> AccountBirthday {
Expand Down Expand Up @@ -612,9 +618,9 @@ pub trait WalletWrite: WalletRead {
/// wallet state, you should use this method to add all of the desired accounts before scanning
/// the chain from the seed's birthday height.
///
/// By convention, wallets should only allow a new account to be generated after funds have
/// been received by the currently-available account (in order to enable automated account
/// recovery).
/// By convention, wallets should only allow a new account to be generated after confirmed
/// funds have been received by the currently-available account (in order to enable automated
/// account recovery).
///
/// [ZIP 316]: https://zips.z.cash/zip-0316
fn create_account(
Expand Down

0 comments on commit 727cddd

Please sign in to comment.